ci: replace battila7/get-version-action (fix set-output & node deprecation)#82
Open
BWibo wants to merge 1 commit into
Open
ci: replace battila7/get-version-action (fix set-output & node deprecation)#82BWibo wants to merge 1 commit into
BWibo wants to merge 1 commit into
Conversation
battila7/get-version-action@v2 declares the ancient node12 runtime and internally uses the deprecated `set-output` workflow command, so it emits both the Node.js and set-output deprecation warnings. Replace it with a small POSIX shell step that derives the version from the release tag and writes to $GITHUB_OUTPUT, preserving the existing `version` and `version-without-v` outputs so downstream references are unchanged. All other actions in this repo already run on the Node 24 runtime, so no version bumps are required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
battila7/get-version-action@v2declares the ancient node12 runtime and internally uses the deprecatedset-outputworkflow command, so it emits both the Node.js 20 andset-outputdeprecation warnings in thebuild-pushrelease job:All other actions in this repo already run on the Node 24 runtime (checkout@v6, setup-java@v5, gradle/actions/setup-gradle@v6, docker/* v4–v7, short-sha@v4.0), so no version bumps are needed here — this is the only remaining offender.
What
Replace the
battila7/get-version-action@v2step indocker-build-push-release.ymlwith a small POSIX shell step that derives the version from the release tag and writes to$GITHUB_OUTPUT:The
version/version-without-voutputs (the only ones consumed downstream, in theCITYDB_TOOL_VERSIONbuild-arg) are preserved, so the rest of the workflow is unchanged.Validation
actionlintclean.v1.2.3/1.2.3tag forms → correctversion/version-without-v.